Repository navigation
Show preview when MouseEditMove in cubic_splines example - #26310
Merged
alice-i-cecile merged 2 commits intoOct 26, 2026
Merged
Conversation
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide, as well as our policy regarding AI usage, and we look forward to reviewing your pull request shortly ✨ |
U-C-S
force-pushed
the
cubic-splines-example-update
branch
from
October 25, 2026 17:28
8f0c97d to
ee6ca75
Compare
alice-i-cecile
added
C-Examples
alice-i-cecile
approved these changes
Oct 25, 2026
alice-i-cecile
left a comment
alice-i-cecile
left a comment
Member
There was a problem hiding this comment.
Tested, this is a nice addition!
DaAlbrecht
approved these changes
Oct 26, 2026
DaAlbrecht
added
S-Ready-For-Final-Review
jbuehler23
approved these changes
Oct 26, 2026
jbuehler23
left a comment
jbuehler23
left a comment
Contributor
There was a problem hiding this comment.
looks good, but it would be a good idea for next time to attach a Showcase directly to the PR description!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Update the examples/math/cubic_splines.rs to also show a preview of new line segment of the curve. The current example only shows the tangent as you
MouseEditMove(aka click and drag the mouse pointer).Solution
Store the preview point and it's tangent in the
ControlPointsstruct and draw it as theMouseEditMovechanges each frame. So, this includes extra logic in theform_curvefn to also include the preview_point.Testing
Tested it in Macbook m2 pro, manually by running the example.
The preview line segment moves accordingly for the
SplineMode::Hermiteas the tangent is only used in this mode.